Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused headway message code #713

Merged
merged 1 commit into from
Oct 20, 2023
Merged

remove unused headway message code #713

merged 1 commit into from
Oct 20, 2023

Conversation

panentheos
Copy link
Collaborator

Summary of changes

This removes various headway-related code that is unused or unreachable:

  • Calculation of dynamic headway ranges from schedule data
  • Display of previous departures
  • Display of first departures
  • Display of headways "up to" a value
  • :none as a potential headway value

@panentheos panentheos requested a review from PaulJKim October 20, 2023 13:57
@github-actions
Copy link

Coverage of commit e26b867

Summary coverage rate:
  lines......: 73.9% (1943 of 2631 lines)
  functions..: 79.4% (538 of 678 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/audio/vehicles_to_destination.ex               |41.1%     56| 100%     9|    -      0
  lib/content/message/headways/bottom.ex                     | 100%      2| 100%     4|    -      0
  lib/content/message/headways/paging.ex                     | 100%      6| 100%     7|    -      0
  lib/engine/scheduled_headways.ex                           |98.5%     68|92.9%    14|    -      0
  lib/signs/utilities/headways.ex                            |95.2%     21| 100%     3|    -      0

Download coverage report

PaulJKim
PaulJKim approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@PaulJKim PaulJKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for cleaning all this up!

@panentheos panentheos merged commit 16b3d6d into main Oct 20, 2023
1 check passed
@panentheos panentheos deleted the bhw/prev-departure branch October 20, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJKim PaulJKim PaulJKim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panentheos @PaulJKim